Posting Bitwarden Review Comments

GitHub Comment Posting Protocol

MUST Analyze all changes before posting anything
MUST Use inline comments for code-specific findings
MUST Use the Bitwarden finding format
FORBIDDEN: Do NOT add "Strengths", "Highlights", or positive observations sections.
FORBIDDEN Do NOT post praise-only inline comments

Finding Format

CRITICAL: Never use # followed by numbers - GitHub will autolink it to unrelated issues/PRs.

Writing "#1" creates a clickable link to issue/PR #1 (not your finding)
"Issue" is also wrong terminology (use "Finding")
Use "Finding" + space + number (no # symbol); aim for under 30 words in sentence

CORRECT FORMAT:

Finding 1: Memory leak detected
Finding 2: Missing error handling

WRONG (DO NOT USE):

❌ Issue #1 (wrong term + autolink)
❌ #1 (autolink only)
❌ Issue 1 (wrong term only)

Inline Comments

Every inline comment MUST:

Reference specific line(s)
State the problem - what breaks or what's the risk?
Provide actionable fix (for ❌ and ⚠️)
Be brief yet clear
Use collapsed sections for comments over 5 lines
Include both opening <details> AND closing </details> tags

Visibility Rule: Only severity + one-line description visible; everything else inside <details> tags.

Template for long comments

[emoji] **[SEVERITY]**: [One-line issue description]

<details>
<summary>Details and fix</summary>

[Code example or specific fix]

[Rationale explaining why]

Reference: [docs link if applicable]
</details>

Summary Comments

Every summary comment MUST:

Be concise - list only finding summaries with file:line references
Not repeat details from inline comments
Limit praise to one or two sentences

Template for PRs with actionable issues

**Overall Assessment:** APPROVE / REQUEST CHANGES

**Critical Issues** (if any):
- [One-line summary with file:line reference]

See inline comments for details.

Template for PRs without actionable issues

**Overall Assessment:** APPROVE

[One neutral sentence describing what was reviewed]

posting-bitwarden-review-comments