code-review

Code Review (Database)

Overview

Engine-aware code review that delegates to the active engine module for engine-specific checks while enforcing the team's merged coding guidelines.

Process

1. Get resolved config from config-resolver (engine, framework, guidelines)

2. Run LSP diagnostics:

   • LSP.getDiagnostics on all changed files
   • Any errors → blocker severity

3. Check against merged guidelines:

   • For each ## section in the resolved guidelines, verify artifact compliance
   • Map violations to severity: ## Forbidden rules → blocker, all others → suggestion

4. Delegate to engine module:

   • Invoke the <engine>-coding skill from the active engine module
   • This checks engine-specific idioms (e.g., T-SQL error handling, PL/pgSQL function patterns, MongoDB schema design)

5. Check framework conventions:

   • Invoke the <engine>-frameworks skill
   • This checks framework patterns (e.g., EF Core migration conventions, Mongoose schema patterns, Flyway naming)

6. Report:

   • Use the same severity format as /db-review
   • Blockers must be fixed before the agent considers the task complete
   • Suggestions are reported but do not block completion

Automatic vs Manual

This skill runs automatically at the end of every coding task (Phase 4). For manual on-demand review, use the /db-review command instead.